Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commented the intro information so it can be reused next year #390

Merged
merged 10 commits into from
Nov 20, 2024

Conversation

SamStaijen
Copy link
Member

Comment out the important introduction related components, so they can be reused next year, but are not used currently.

It ain't pretty, but it works :)

@SamStaijen SamStaijen linked an issue Oct 8, 2024 that may be closed by this pull request
@SamStaijen SamStaijen self-assigned this Oct 8, 2024
@TobiasDeBruijn
Copy link
Member

Could we do this via contentful perhaps?

@stickyPiston
Copy link
Member

stickyPiston commented Oct 8, 2024

Id favour doing to it via contentful too, or let it be done automatically based on the date in the year

@SamStaijen
Copy link
Member Author

It favour doing to it via contentful too, or let it be done automatically based on the date in the year

let's look at it in 2 hours!

@stickyPiston
Copy link
Member

Now that I've figured out how to access contentful, it seems that we could easily add a checkbox for the intro information that would enable or disable it. And since publishing changes in contentful (should) cause a re-deploy, I definitely think this is the best solution.

@SilasPeters
Copy link
Member

Then I would be highly in favor of making this depend on contentfull I suggest we rename this PR and do that instead

@stickyPiston
Copy link
Member

stickyPiston commented Oct 17, 2024

Unpublishing the intro information currently results in a build error, so i've added a fix so that unpublishing just ignores the intro information and patches the rest of the home page layout. Love to have a quick review on this from someone else, so we can merge this.

@SamStaijen
Copy link
Member Author

this has been approved a month ago, can we merge? I see Silas has approved

@stickyPiston
Copy link
Member

Yes, we totally can ^_^

@stickyPiston stickyPiston merged commit 7e1a4a6 into development Nov 20, 2024
2 checks passed
@stickyPiston stickyPiston deleted the 387-remove-introduction-section branch November 20, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove introduction section
5 participants